Support for timezone argument in calendar operators #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportMain: 91.10% | PR: 91.12% | Diff: 0.02 ✅ |
ianspektor
approved these changes
Nov 6, 2023
| from temporian.test.utils import assertOperatorResult, i32 | ||
|
|
||
|
|
||
| class CalendarTimezoneTest(TestCase): |
There was a problem hiding this comment.
I feel these tests might be easier to miss here than if they were in each operator's test file - is there a reason to have them here together?
There was a problem hiding this comment.
The reason is I don't want to duplicate the very specific setUp() code, and also it's easier to check that I'm testing that the argument is connected in all operators.
I agree it's easy to miss the file though, so I renamed it to test_base_timezone and now it appears on top together with test_base.py (which already existed and tests other generic stuff).
Coverage reportMain: 91.11% | PR: 91.13% | Diff: 0.02 ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to specify the timezone in calendar operators, using the timezone name (e.g:
America/Montevideo) or an offset in hours (e.g:-3) in the argumenttz.To ease serialization, the core operator only receives the offset in hours.