Cleanup tests restructure #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DonBraulio
commented
Nov 2, 2023
DonBraulio
commented
- Remove some folders that don't make sense after tests restucture completed.
- Update create_operator.py to the new tests format.
DonBraulio
force-pushed
the
cleanup-tests-restructure
branch
from
1976cfa
to
ff1b461
Compare
DonBraulio
force-pushed
the
cleanup-tests-restructure
branch
from
8de45d4
to
572be01
Compare
Coverage reportMain: 91.10% | PR: 91.10% | Diff: 0.00 ✅ |
ianspektor
approved these changes
Nov 6, 2023
Comment on lines
+299
to
+302
| @parameterized.parameters( | ||
| {{"in_timestamps": [0.0, 1.0], "out_timestamps": [0.0, 1.0]}}, | ||
| {{"in_timestmaps": [1.0, 2.0], "out_timestamps": [1.0, 2.0]}}, | ||
| ) |
There was a problem hiding this comment.
I think the most probable scenario is not using parameterized rather than using it? I'd leave it out of the template (and maybe add a commented line with the import or a sentence nudging the developer towards using it if needed?)
There was a problem hiding this comment.
I think it's a positive thing to induce ourselves to use parametrized tests, since you tend to add more test cases and edge cases. Also, the effort to remove this is negligible. Don't you agree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.