Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging.debug logs in data import methods. #305

Merged
merged 3 commits into from Nov 8, 2023
Merged

Add logging.debug logs in data import methods. #305

merged 3 commits into from Nov 8, 2023

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Nov 5, 2023

Also add new benchmarks representative of real case application scenarios

@achoum achoum marked this pull request as ready for review November 5, 2023 18:57
Copy link

github-actions bot commented Nov 5, 2023

Coverage report

Main: 91.10% | PR: 91.10% | Diff: 0.00 ✅

Copy link
Collaborator

@ianspektor ianspektor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 left some very nits

temporian/implementation/numpy/data/dtype_normalization.py Outdated Show resolved Hide resolved
temporian/implementation/numpy/data/dtype_normalization.py Outdated Show resolved Hide resolved
temporian/implementation/numpy/data/io.py Outdated Show resolved Hide resolved
@achoum
Copy link
Collaborator Author

achoum commented Nov 7, 2023

Thanks

Copy link

github-actions bot commented Nov 7, 2023

Coverage report

Main: 91.11% | PR: 91.11% | Diff: 0.00 ✅

@achoum achoum merged commit 3c63358 into main Nov 8, 2023
20 checks passed
@achoum achoum deleted the gbm_debug branch November 8, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants