Added timestamp param to to_pandas #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportMain: 91.16% | PR: 91.16% | Diff: 0.00 ✅ |
ianspektor
approved these changes
Dec 12, 2023
temporian/io/pandas.py
Outdated
| @@ -132,6 +133,7 @@ def to_pandas( | |||
| np.string_ or np.bytes) to Pandas strings (equivalent to np.str_). | |||
| timestamp_to_datetime: IF true, cast Temporian timestamps to datetime64 | |||
| when is_unix_timestamp is set to True. | |||
| timestamps: IF true, the timestamps are included as a column. | |||
There was a problem hiding this comment.
super nit, change lowercase f in IF (same in the previous param)
javiber
force-pushed
the
add-timestamp-param-to-pandas
branch
from
10fd0d8
to
d3bf61b
Compare
Coverage reportMain: 91.16% | PR: 91.16% | Diff: 0.00 ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.