Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few fixes #337

Merged
merged 4 commits into from Jan 12, 2024
Merged

A few fixes #337

merged 4 commits into from Jan 12, 2024

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Jan 12, 2024

No description provided.

@achoum achoum marked this pull request as ready for review January 12, 2024 10:11
@github-actions GitHub Actions
Copy link

Coverage report

Main: 91.18% | PR: 91.19% | Diff: 0.01 ✅

1 similar comment
@github-actions GitHub Actions
Copy link

Coverage report

Main: 91.18% | PR: 91.19% | Diff: 0.01 ✅

ianspektor
ianspektor approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@ianspektor ianspektor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to add a test to ensure the tz conversion is working as expected (in a follow up PR). thanks!

@github-actions GitHub Actions
Copy link

Coverage report

Main: 91.18% | PR: 91.19% | Diff: 0.01 ✅

@ianspektor ianspektor merged commit b20a0ad into main Jan 12, 2024
17 of 18 checks passed
@ianspektor ianspektor deleted the gbm_import branch January 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianspektor ianspektor ianspektor approved these changes

@rstz rstz Awaiting requested review from rstz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achoum @ianspektor