352: Enhancement: Support tp.to_numpy() for temporian

[nagavenkateshgavini]

PR to #352

• add support for tp.to_numpy()
• Provide timestamps: bool = True argument
• Provide timestamp_to_datetime: bool = True argument
• Add tests in temporian/io/test/numpy_test.py
• test_correct
• test_no_index
• test_no_timestamps
• test_timestamp_to_datetime_param
• test_empty_event_set
• Add doc string

[javiber]

Thanks for the contribution! Code looks good!

I left some ideas to improve the tests

[nagavenkateshgavini]

@javiber
I've addressed all your feedback, with the only remaining question being whether to sort the array before comparing it or not.

[javiber]

We will tackle the sorting in another issue, I left you a small comment but there is something more important that I missed in the first review, we need to format the test file using black.

1. run black temporian/io/test/numpy_test.py. Black should already be installed, you might need to activate the virtualenv (poetry shell) or pre-pend poetry run to the command
2. add, commit and push the changes to the file

[javiber]

@nagavenkateshgavini There is still a formatting error, you can run black --check . locally to get more info about the problem

[nagavenkateshgavini]

@javiber
just made a commit after reformatting

$ black --check .                        
Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install black[jupyter]``
All done! ✨ 🍰 ✨
307 files would be left unchanged.

[nagavenkateshgavini]

@javiber
Could you please provide your approval for the pending workflow checks?

[ianspektor]

Hey @nagavenkateshgavini! Docs build was fixed in #386, please merge main to your PR to fix the jupyter: command not found error. Approving the workflows now. Thanks!

[nagavenkateshgavini]

@ianspektor
I merged my branch with the main, and the docs test was successful.
Could you please approve the workflows? Hopefully, this will be the last workflow test for this PR.

cc: @javiber

[ianspektor]

Congrats and thank you for your contribution @nagavenkateshgavini! 🥳

[nagavenkateshgavini]

Thank you, @ianspektor, for the amazing insights; this is truly fascinating. And a huge thank you to @javiber for your constant support and guidance throughout this process.