Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some beam operators (w3) #400

Merged
merged 11 commits into from Mar 28, 2024
Merged

Implement some beam operators (w3) #400

merged 11 commits into from Mar 28, 2024

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Mar 19, 2024

Operators

  • DROP_INDEX
  • PROPAGATE
  • GLUE
  • GREATER_SCALAR
  • LESS_SCALAR
  • FILTER
  • TIMESTAMPS
  • RESAMPLE
  • SUBTRACTION
  • FILTER_EMPTY_INDEX
  • CAST
  • LEAK
  • UNIQUE_TIMESTAMPS

Copy link

Coverage report

Main: 91.32% | PR: 91.52% | Diff: 0.21 ✅

Copy link

Coverage report

Main: 91.32% | PR: 89.81% | Diff: -1.50 ⚠️

Copy link

Coverage report

Main: 91.32% | PR: 89.52% | Diff: -1.80 ⚠️

Copy link

Coverage report

Main: 91.32% | PR: 89.48% | Diff: -1.84 ⚠️

Copy link

Coverage report

Main: 91.57% | PR: 89.48% | Diff: -2.09 ⚠️

@achoum achoum marked this pull request as ready for review March 21, 2024 11:15
Copy link

Coverage report

Main: 91.57% | PR: 89.48% | Diff: -2.09 ⚠️

@achoum achoum requested a review from javiber March 26, 2024 18:27
@achoum achoum changed the title Implement some beam operators Implement some beam operators (w3) Mar 27, 2024
Copy link
Collaborator

@javiber javiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just left a few questions

temporian/beam/operators/drop_index.py Show resolved Hide resolved
temporian/beam/operators/drop_index.py Show resolved Hide resolved
temporian/beam/operators/drop_index.py Show resolved Hide resolved
temporian/beam/operators/timestamps.py Show resolved Hide resolved
@achoum
Copy link
Collaborator Author

achoum commented Mar 28, 2024

Thanks!

@achoum achoum merged commit d4419cb into main Mar 28, 2024
21 of 22 checks passed
@achoum achoum deleted the gbm_work_3 branch March 28, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants