Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Use lower case names for split values #42

Open
cfezequiel opened this issue Oct 14, 2020 · 3 comments
Open

Use lower case names for split values #42

cfezequiel opened this issue Oct 14, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cfezequiel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Change split values from all caps to lower case.
This makes file/directory naming more consistent with the split.

Describe the solution you'd like
TRAIN -> train
VALIDATION -> validation
TEST -> test

Describe alternatives you've considered

  1. No change
  • There's a bit of skew when it comes to mapping split value with file/dir name.
@cfezequiel cfezequiel added enhancement New feature or request good first issue Good for newcomers labels Oct 14, 2020
@AnshuTrivedi
Copy link

@cfezequiel May you help me better understand what changes have to make ?
I would love to contribute !

@cfezequiel
Copy link
Contributor Author

Hi @AnshuTrivedi , thanks for the comment, and apologies for the delay in response. It seems I wasn't getting any notifications for non-PR comments in this repo (should be fixed now).
Regarding this issue, the idea is to change the dataset split values that the tool uses from 'TRAIN', 'VALIDATION', 'TEST' to 'train', 'validation', 'test'. This would affect the following:

Input CSV/Pandas DataFrame: the split column should have train, 'validation', 'test' as acceptable values
Input image directory: the image directory should now have the following structure

train/
  label0/
    image00
    ...
  label1/
  ...
validation/
  label0/
     ...
  ...
test/
  label0/
  ...

It's basically a cosmetic change.
Let us know if you want to take this on.

@Samad999777
Copy link

Hey @cfezequiel is this still open to do? I would be interested to do it.

Samad999777 added a commit to Samad999777/tensorflow-recorder that referenced this issue May 22, 2021
Samad999777 added a commit to Samad999777/tensorflow-recorder that referenced this issue May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants