Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update message #340

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Update message #340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ef27c2
Updates error message for version endpoint
sofyakurilova Mar 18, 2024
922a5bd
Merge branch 'dev' into bug/version_instructions
jboddey Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions framework/python/src/api/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,8 @@ async def get_version(self, response: Response):
if version_check.status_code != 200:
response.status_code = 500
LOGGER.error(version_check.content)
return self._generate_msg(False, "Failed to fetch latest version")
return self._generate_msg(False, "Failed to fetch latest version. " +
"Please, check the internet connection")

# Extract version number from response, removing the leading 'v'
latest_version_no = version_check.json()["name"].strip("v")
Expand All @@ -288,7 +289,8 @@ async def get_version(self, response: Response):
response.status_code = 500
LOGGER.error("Failed to fetch latest version")
LOGGER.debug(e)
return self._generate_msg(False, "Failed to fetch latest version")
return self._generate_msg(False, "Failed to fetch latest version. " +
"Please, check the internet connection")

async def get_reports(self, request: Request):
LOGGER.debug("Received reports list request")
Expand Down
Loading