Revert 3 american option baron adesi whaley #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion input and description editing vanilla prices to take in cost_of_carries and riskless_rate while keeping compatibility with version that takes in discount_factors. adding reference to american_options adding skeleton for american pricing call option written down starting to write down put small progress with put option progress with put, refactoring to make slightly nicer further progress on calculating s** crit for put first attempt at tests - imports not working importing option price from black scholes directly renaming a few modeuls adding numpy dep; responding to PR comments test now failing on assertion error adding more tests and correcting a typo correct equation all tests passing with outputs. will now look for bugs; almost done stuff
…haley modifying vanilla price input and description. setting up american op…
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.