Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making changes to example notebooks after an API update #1501

Merged
merged 14 commits into from Dec 3, 2020

Conversation

kiddinn
Copy link
Contributor

@kiddinn kiddinn commented Dec 3, 2020

This PR updates the example notebooks to work with the latest API client changes, mainly the move to a search object.

@google-cla google-cla bot added the cla: yes label Dec 3, 2020
notebooks/Stolen_Szechuan_Sauce_Analysis.ipynb Outdated Show resolved Hide resolved
notebooks/colab-timesketch-demo.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is still a WIP those changes have not yet been made

@kiddinn kiddinn marked this pull request as ready for review December 3, 2020 15:09
@kiddinn kiddinn requested a review from berggren December 3, 2020 15:09
@kiddinn kiddinn merged commit d5f8aea into google:master Dec 3, 2020
@kiddinn kiddinn deleted the colab_update branch December 3, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants