Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API client: Return all field for analysis sessions #2504

Merged
merged 5 commits into from Nov 14, 2023
Merged

API client: Return all field for analysis sessions #2504

merged 5 commits into from Nov 14, 2023

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Jan 5, 2023

This change brings more data into what can be received by the Python API client.

@tomchop tomchop requested a review from berggren January 6, 2023 10:55
@tomchop tomchop changed the title timesketch_api_clietn: Expose all items from DB instead of arbitrary subset. timesketch_api_client: Expose all items from DB instead of arbitrary subset. Jan 6, 2023
@berggren berggren changed the title timesketch_api_client: Expose all items from DB instead of arbitrary subset. API client: Return all field for analysis sessions Mar 21, 2023
@berggren berggren requested a review from jkppr March 21, 2023 07:11
@berggren
Copy link
Contributor

Added @jkppr to review form the analysis side.

@tomchop
Copy link
Collaborator Author

tomchop commented Mar 21, 2023

Let's close this for now, as I don't remember exactly what my use-case was. If I ever run into it again, I'll make sure to reopen and address comments.

@tomchop tomchop closed this Mar 21, 2023
@jkppr
Copy link
Collaborator

jkppr commented Nov 14, 2023

Re-opening this PR, since we finally remember why we needed this change.

  • Use-case: Make the timesketch api client compatible with the dftimewolf timesketch module that handles analyzer results & status.
  • The change was tested internally for ~10 month now, without any known problems "downstream".

Next step: Test & merge the change.

@jkppr jkppr reopened this Nov 14, 2023
jkppr
jkppr approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkppr jkppr dismissed berggren’s stale review November 14, 2023 16:26

Dismiss requested changes.

@jkppr jkppr merged commit 6ced6ff into google:master Nov 14, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaegeral jaegeral jaegeral left review comments

@jkppr jkppr jkppr approved these changes

@berggren berggren berggren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomchop @berggren @jkppr @jaegeral