Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old feature extractor analyzer #2969

Merged
merged 5 commits into from Nov 3, 2023

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Nov 2, 2023

This PR removes the "old" feature extractor analyzer and replaces it with the new feature extraction plugin analyzer. The "old" regex based analyzer was moved into the new plugin one as part of #2910 .

  • Removes the "old" feature extraction analyzer.
  • Removes the old feature.yaml config to regex_features.yaml to better reflect its purpose.
    • The analyzer is backwards compatible with the old filename. The new one will be preferred though.
    • Replaced features.yaml with regex_features.yaml in all set-up/deployment/config files.
    • Added winevt_features.yaml to all deployment scripts.
  • Removes regex based extractions from the regex_features.yamlconfig that are now covered by the new winevt_features.yaml config.
  • Takes care of dependency naming within the analyzers.
  • Flips the run order for plugins: regex first, then the rest.
  • Adds a small check in the winevt extraction plugin to add info comments only if they do not exist yet.

@jkppr jkppr self-assigned this Nov 2, 2023
@jkppr jkppr added this to the Release: 20231206 milestone Nov 2, 2023
@jkppr jkppr requested a review from berggren November 2, 2023 15:33
@jkppr
Copy link
Collaborator Author

jkppr commented Nov 2, 2023

@roshanmaskey fyi

@jkppr jkppr requested a review from berggren November 3, 2023 07:07
@jkppr jkppr merged commit c1e0e55 into google:master Nov 3, 2023
24 checks passed
@jkppr jkppr deleted the analyzers_remove_old_feature_extractor branch November 3, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants