Implement user management (create, list, get) via API #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
I changed the UserResource, so that it does not check for admin privileges anymore. Might be useful to limit details like mail address to admin users In the future. |
|
Hi @lo-chr thanks for contributing! I'll review this on Friday, Jan 26. |
berggren
requested changes
Feb 1, 2024
|
I'll fix this over the weekend! Thank you for the review. |
Fix copy and paste Co-authored-by: Johan Berggren <jberggren@gmail.com>
Co-authored-by: Johan Berggren <jberggren@gmail.com>
|
Thanks for contributing! |
|
Thank your for the reviews and advice. I learned one or two things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most of the features, mentioned here: #3023
This PR is a first step into further capabilities of user management via API, although it lacks the ability to manage a particular user itself.
I also added some features to the testing framework, enabling the test of "admin only" tests, via creating admin users during test setup.
Checks
Closing issues
closes #3023