Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding form validation to prevent names > 255 char. #3026

Merged
merged 5 commits into from Jan 26, 2024
Merged

Adding form validation to prevent names > 255 char. #3026

merged 5 commits into from Jan 26, 2024

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Jan 25, 2024

This PR introduces some simple form validation for Sketch, Timeline and View names to be compliant with the database schema.

  • Adding validation to the API endpoints with an actionable error message.
  • Adding validation to the frontend with an actionable error message.

Closing issues

closes #3025

@jkppr jkppr added the Frontend label Jan 25, 2024
@jkppr jkppr requested a review from berggren January 25, 2024 10:32
@jkppr jkppr self-assigned this Jan 25, 2024
berggren
berggren approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I still think it is kind of silly we have this limitation :) I'll probably change it next time we update the schema.

@berggren berggren added this to the Release: 20240207 milestone Jan 26, 2024
@jkppr jkppr merged commit 57c585c into google:master Jan 26, 2024
23 of 24 checks passed
@jkppr jkppr deleted the truncate_sketch_name branch January 26, 2024 14:17
lo-chr pushed a commit to lo-chr/timesketch that referenced this pull request Jan 28, 2024
@jkppr @lo-chr
Adding form validation to prevent names > 255 char. (google#3026)
91c6e9e 
* Introduce name field validation in front & backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees

@jkppr jkppr

Labels
Frontend
Projects
None yet
Milestone
Release: 20240207
Development

Successfully merging this pull request may close these issues.

Timesketch form validation bug
2 participants
@jkppr @berggren