Dynamic timefilter #314
Merged
Dynamic timefilter #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imesketch into ts-dynamic-timefilter
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
berggren
reviewed
May 22, 2017
| var offsetRegexp = /(.*?)(-|\+|\+-|-\+)(\d+)(y|d|h|m|s|M|Q|w|ms)/g; | ||
| var match = offsetRegexp.exec(datevalue); | ||
| if (match != null) { | ||
| match[1] = moment(match[1],"YYYY-MM-DD HH:mm:ssZZ"); |
There was a problem hiding this comment.
It's a bit hard to follow here without looking at the regexp. Could you put the mathed expressions in variables perhaps? Just to make it easier to read.
berggren
reviewed
May 22, 2017
|
Thanks. Added regexp matches in variables for code readability. |
|
Ref issue: #1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added more dynamic date/time searching.