Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dedup: false in collection doesn't work? #122

Closed
everpeace opened this issue May 30, 2020 · 4 comments · Fixed by #123
Closed

dedup: false in collection doesn't work? #122

everpeace opened this issue May 30, 2020 · 4 comments · Fixed by #123

Comments

@everpeace
Copy link
Contributor

I set

collections:
  id: foo
  dedup: false
  rules:
  - rule-a

however, the output of rule rule-a in the collection foo looks like dedeup-ed

image

Is this behavior expected?
@tstromberg
Copy link
Collaborator

Nice find. It seems that the code which checks for the dedup value was dropped during a refactor. I'll send a PR in to address it.

@tstromberg tstromberg mentioned this issue May 30, 2020
Merged
@tstromberg
Copy link
Collaborator

Please let me know if #123 fixes this. I'll merge it once confirmed, or some time soon otherwise.

@everpeace
Copy link
Contributor Author

everpeace commented May 31, 2020 •
edited

Thanks for the quick fix! It looks like dedup-ed correctly! but still shows 'previously listed items omitted: ...' message. I think it shouldn't show up here in this case.

image

@tstromberg
Copy link
Collaborator

Fixed. Thank you for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect 'dedup: false' collection state tstromberg/triage-party
2 participants
@tstromberg @everpeace