Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Test Coverage of sparse_merkle_tree_test.go #1499

Closed
gdbelvin opened this issue Apr 5, 2019 · 1 comment
Closed

Increase Test Coverage of sparse_merkle_tree_test.go #1499

gdbelvin opened this issue Apr 5, 2019 · 1 comment
Labels
Low Priority tests Related to tests or test coverage.

Comments

@gdbelvin
Copy link
Contributor

gdbelvin commented Apr 5, 2019

The inclusion proof tests in sparse_merkle_tree_test.go do not exercise any validation logic.
Ideally, we could instantiate these tests with an in-memory tree implementation and verify with the verifiers in client.

Since mocks are not recommended in Go, this would also bring the tests better in-line with best practice.
@gdbelvin gdbelvin added the tests Related to tests or test coverage. label Apr 5, 2019
@gdbelvin gdbelvin mentioned this issue Apr 5, 2019
Merged
2 tasks
@pav-kv
Copy link
Contributor

pav-kv commented Jan 21, 2021

Closing in favour of #2284.

@pav-kv pav-kv closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low Priority tests Related to tests or test coverage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gdbelvin @pav-kv @paulmattei