Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Hide node_revision and node_id in message Node #350

Closed
gdbelvin opened this issue Feb 1, 2017 · 2 comments
Closed

API: Hide node_revision and node_id in message Node #350

gdbelvin opened this issue Feb 1, 2017 · 2 comments
Assignees
@Martin2112
Labels
cleanup
Milestone
Log M7

Comments

@gdbelvin
Copy link
Contributor

gdbelvin commented Feb 1, 2017

Public clients only need an array of neighbor hashes to verify proofs.
Including extra data invites API missuse.
@Martin2112
Copy link
Contributor

This was useful for diagnosing bugs in the Merkle path code for proofs as it allows inspection of which nodes in the proof were recomputed. I'm pretty confident in that code now so I think we can rely on the tests.

@Martin2112 Martin2112 added this to the Log M7 milestone Mar 28, 2017
@Martin2112 Martin2112 self-assigned this Mar 29, 2017
@Martin2112 Martin2112 mentioned this issue Mar 29, 2017
Merged
@Martin2112
Copy link
Contributor

Opened #499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Martin2112 Martin2112

Labels
cleanup
Projects
None yet
Milestone
Log M7
Development

No branches or pull requests
2 participants
@gdbelvin @Martin2112