Fix incorrect usages of quota related protos #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly tests but a couple of cases in the implementation.
gdbelvin
approved these changes
Jun 27, 2019
|
Towards #1738. |
gdbelvin
added a commit
to gdbelvin/trillian
that referenced
this pull request
Jul 2, 2019
* master: Fix incorrect copying / other usages of trillian log api protos. (google#1748) Fix storage API Get / Set root passing SignedLogRoot proto by value (google#1735) Fix cases where trillian.Tree protos were being incorrectly passed by value. (google#1734) Increase Cloud Build timeout from 15 mins to 20 mins Remove reference to etcd-service.yaml from kubernetes/create.sh Enable goproxy in travis (google#1744) Fix nits (google#1743) Update build instructions in README (google#1742) Stop removing ConfigMaps when deploying Trillian on Kubernetes Fix incorrect usages of quota related protos (google#1736) Remove GO111MODULE build arg from Cloud Build configs Added interceptor for Map WriteLeaves added in google#1655. (google#1732) Make namespace configurable in Kubernetes configs Remove unused Snapshot function (google#1729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't find as many of these.
Checklist