Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure nodes that are not part of the compact merkle tree state #180

Merged
merged 3 commits into from Oct 4, 2016
Merged

Ensure nodes that are not part of the compact merkle tree state #180

merged 3 commits into from Oct 4, 2016

Commits on Oct 3, 2016

  1. Ensure nodes that are not part of the compact merkle tree state 

    for given tree size are set to nil when new leaves are added.

Check using an invariant after each AddLeaf in the tests.

Fix test data to have nils in the appropriate places.
    @phad
    phad committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    cf637f1 View commit details
    Browse the repository at this point in the history

  2. Add CompactMerkleTree tests checking the root hash at varying tree 

    sizes.

Test data generated with the code to write nil in 'nodes []trillian.Hash'
disabled, so that it is known to be good with the existing CompactMerkleTree.

With the new 'write nil' code enabled this acts as a regression check.
    @phad
    phad committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    0699c43 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2016

  1. Code review fixes

    @phad
    phad committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    42240d8 View commit details
    Browse the repository at this point in the history