OptionalSubject<String> comparison failure message ignores custom name

[kaibolay]

assertThat(someOptionalFoobarString).named("FroBar").hasValue(expected);

results in "Optional has an incorrect value. expected: but was:".

What happened to the custom name "FooBar"? Looks like it's simply ignored:

https://github.com/google/truth/blob/master/core/src/main/java/com/google/common/truth/OptionalSubject.java#L61-L64

  if (!getSubject().get().equals(expected)) {
    if (getSubject().get() instanceof String) {
      this.failureStrategy.failComparing("Optional<String> has an incorrect value.",
          (String) expected, (String) actual);

[cgruber]

Fix in progress

On Sat, Nov 15, 2014, 04:59 kaibolay notifications@github.com wrote:

assertThat(someOptionalFoobarString).named("FroBar").hasValue(expected);

results in "Optional has an incorrect value. expected: but was:".

What happened to the custom name "FooBar"? Looks like it's simply ignored:

https://github.com/google/truth/blob/master/core/src/main/java/com/google/common/truth/OptionalSubject.java#L61-L64

if (!getSubject().get().equals(expected)) {
if (getSubject().get() instanceof String) {
this.failureStrategy.failComparing("Optional has an incorrect value.",
(String) expected, (String) actual);

—
Reply to this email directly or view it on GitHub
#156.

[kluever]

Fix submitted internally . Should be mirror out soon.