Test IterableSubject methods on objects that don't implement hashCode() #176

cpovirk · 2015-03-14T20:05:25Z

Such objects are at least a little evil, but they exist in one or two Google-internal projects. If we currently support this, then we should continue to do so, or at least we should have a test that lets us know that we're breaking it so that we don't do so by mistake.

cpovirk · 2015-03-14T20:35:57Z

By "don't implement hashCode()", I was thinking more of classes that implement it by throwing UnsupportedOperationException. But I just realized that the particular case I was worse, overriding equals() but not hashCode(). But I suppose that a test for the UnsupportedOperationException will test that, too, for better or for worse.

…elements don't implement hashCode() (e.g., ProtoBuf's MessageSet!) See []where the user can't use .containsExactlyElementsIn(). This at least partially addresses #176 ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89605122

…elements don't implement hashCode() (e.g., ProtoBuf's MessageSet!) This at least partially addresses #176 ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89605122

cpovirk · 2022-07-25T18:13:59Z

We just got a report internally that failing tests still call hashCode here:

truth/core/src/main/java/com/google/common/truth/SubjectUtils.java

Line 267 in f149531

stringValueToItemsToCheck.put(String.valueOf(itemToCheck), itemToCheck);

I wonder if we could get away with using an ArrayListMultimap (which I don't think would use hashCode) instead of a HashMultimap?

[Update: I did that.]

…hrow an exception. We'd rather they didn't, but let's do what we can... :( (progress toward #176) RELNOTES=n/a PiperOrigin-RevId: 463138856

…hrow an exception. We'd rather they didn't, but let's do what we can... :( (progress toward #176) RELNOTES=n/a PiperOrigin-RevId: 463143598

raghsriniv added the P3 not scheduled label Jun 24, 2019

nick-someone added the type=other Miscellaneous activities not covered by other type= labels label Aug 6, 2019

copybara-service bot mentioned this issue Jul 25, 2022

Make another code path resilient to hashCode implementations that throw an exception. #1005

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test IterableSubject methods on objects that don't implement hashCode() #176

Test IterableSubject methods on objects that don't implement hashCode() #176

cpovirk commented Mar 14, 2015

cpovirk commented Mar 14, 2015

cpovirk commented Jul 25, 2022 •

edited

Loading

Test IterableSubject methods on objects that don't implement hashCode() #176

Test IterableSubject methods on objects that don't implement hashCode() #176

Comments

cpovirk commented Mar 14, 2015

cpovirk commented Mar 14, 2015

cpovirk commented Jul 25, 2022 • edited Loading

cpovirk commented Jul 25, 2022 •

edited

Loading