Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the outdated link of google's java style guide #330

Closed
wants to merge 1 commit into from
Closed

Fix the outdated link of google's java style guide #330

wants to merge 1 commit into from

Conversation

tianyin
Copy link
Contributor

@tianyin tianyin commented Jul 3, 2017

Hi,

In CONTRIBUTING.md, the link of Google Java style guide is outdated (given a 404 error code).
The current Java style guide is at
https://google.github.io/styleguide/javaguide.html

(used by the google/guava project
https://github.com/google/guava/blob/master/CONTRIBUTING.md)

This PR is a simple update for the link.

@dimo414
Copy link
Contributor

dimo414 commented Jul 3, 2017

Thanks for the contribution. I notice you submitted the same fix to the Guice repo; just in case you're looking for other instances, it'll be easier for us to fix internally and push out than for you to send separate pull requests to each project you find.

@tianyin
Copy link
Contributor Author

tianyin commented Jul 3, 2017

@dimo414 thanks! i'm just looking at truth, jimfs, and guice, and find they're in common.

feel free to ignore any of these PRs.
(sorry for the duplicates!)

@dimo414
Copy link
Contributor

dimo414 commented Jul 3, 2017

Perfect, thanks. I'll get them fixed (and credit you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants