Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go generated files for go ver 1.1[3-5]x #128

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Update go generated files for go ver 1.1[3-5]x #128

merged 1 commit into from
Apr 14, 2021

Conversation

nerdinary
Copy link
Collaborator

@nerdinary nerdinary commented Apr 14, 2021

go generate now adds a "." at the end of comment strings. updating the generated files to prevent test failures

eg. https://github.com/google/ts-bridge/runs/2063426061

go.mod will produce a diff for go 1.16x as our module dependencies are pinned to ver 1.13. This will be fixed in #110

@nerdinary nerdinary changed the title Update go generated files for go ver 1.16x Update go generated files for go ver 1.1[3-5]x Apr 14, 2021
@nerdinary nerdinary requested a review from rjerrems April 14, 2021 05:44
Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nerdinary nerdinary merged commit 95e5f4e into master Apr 14, 2021
@nerdinary nerdinary deleted the mocks branch November 3, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants