Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #60221: Fix null pointer dereference in tsl::profiler::CreateStub #576

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

PR #60221: Fix null pointer dereference in tsl::profiler::CreateStub

Imported from GitHub PR tensorflow/tensorflow#60221

The bug was found by Svace static analyzer:

  1. channel may be null
  2. it is passed to grpc::ProfileAnalysis::NewStub(channel)
  3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel)
  4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences channel via channel->RegisterMethod(name)

cc @mihaimaruseac
Copybara import of the project:

--
232683a9b9e567f43239592b958e4302c257d85d by Alexey Vishnyakov vishnya@ispras.ru:

Fix null pointer dereference in tsl::profiler::CreateStub

The bug was found by Svace static analyzer:

  1. channel may be null
  2. it is passed to grpc::ProfileAnalysis::NewStub(channel)
  3. then passed to grpc::ProfileAnalysis::Stub::Stub(channel)
  4. then constructor grpc::internal::RpcMethod::RpcMethod() dereferences
    channel via channel->RegisterMethod(name)

Merging this change closes #60221

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#60221 from SweetVishnya:rpc-profiler-client-nullptr 232683a9b9e567f43239592b958e4302c257d85d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
0 participants