Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turbiniactl config command #306

Closed
aarontp opened this issue Nov 16, 2018 · 8 comments
Closed

Add turbiniactl config command #306

aarontp opened this issue Nov 16, 2018 · 8 comments

Comments

@aarontp
Copy link
Member

aarontp commented Nov 16, 2018

It would be nice to have a 'turbiniactl config' command that would just print out the current config. It's also easy to just cat the config file, but it would be nice to have the command to show which config was loaded (because it can be loaded from several different places).

@aarontp aarontp changed the title Add turbiniactl config Add turbiniactl config command Nov 16, 2018
@shubhodeep9
Copy link

Hi @aarontp
I am interested to contribute.

@aarontp
Copy link
Member Author

aarontp commented Jan 8, 2019

@shubhodeep9 Awesome, let me know if you're still interested! Sorry for the delay, I was out during the holidays. I think we just need to add a command line flag for something like --print-config, and then maybe add a method to turbinia/config/init.py to return a text representation of the loaded config that will be printed from turbiniactl.py.

@shubhodeep9
Copy link

@aarontp I am still interested.

@aarontp
Copy link
Member Author

aarontp commented Jan 8, 2019 via email

@shubhodeep9
Copy link

@aarontp do you want the feature to validate the config too? I see while loading there is a validation.

@aarontp
Copy link
Member Author

aarontp commented Jan 9, 2019

@shubhodeep9 It would be a nice to have, but not required. Another nice to have would be to specify an arbitrary config file. Maybe instead of --print_config, the behavior could be a --check_config flag that when specified without any arguments validates and prints the current config file, but when a file is specified, it will load that config for validation/printing.

@shubhodeep9
Copy link

@aarontp So I will work on having

  • --check_config [filename] where filename will default be for ['.turbiniarc', 'turbinia.conf', 'turbinia_config.py'] or the name provided.
  • it will validate the config, and output the file and the validations

Correct me on 1st point, I am yet to confirm on how a config file is chosen between 3, and if one can give any other name apart from the 3.

@aarontp
Copy link
Member Author

aarontp commented Sep 27, 2019

Fixed in #395 and #422

@aarontp aarontp closed this as completed Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants