Add workaround for pinfo non-json warning output #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to cherry pick this on top of the last release! |
aarontp
pushed a commit
that referenced
this pull request
Jan 16, 2024
aarontp
pushed a commit
that referenced
this pull request
Jan 17, 2024
113ll3
reviewed
Jan 17, 2024
| @@ -1070,6 +1070,8 @@ def _validate(self): | |||
| log.info(f'Running pinfo.py to validate PlasoFile {self.local_path}') | |||
| command = subprocess.run(cmd, capture_output=True, check=True) | |||
| storage_counters_json = command.stdout.decode('utf-8').strip() | |||
| # pinfo.py might print warnings (non-json) so we only need to last line of output | |||
| storage_counters_json = storage_counters_json.splitlines()[-1] | |||
wajihyassine
pushed a commit
that referenced
this pull request
Feb 14, 2024
* add workaround for pinfo warning output (#1418) * Update version to 20231116.1 * Fix plaso dependencies (#1420) * fix deps * fix test * Update version to 20231116.2 * Fix plaso dependencies (#1420) * fix deps * fix test * update docs link --------- Co-authored-by: hacktobeer <ramsesdebeer@gmail.com> Co-authored-by: Aaron Peterson <aaronp@gmail.com>
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Feb 28, 2024
jleaniz
added a commit
to jleaniz/turbinia
that referenced
this pull request
Feb 28, 2024
* add workaround for pinfo warning output (google#1418) * Update version to 20231116.1 * Fix plaso dependencies (google#1420) * fix deps * fix test * Update version to 20231116.2 * Fix plaso dependencies (google#1420) * fix deps * fix test * update docs link --------- Co-authored-by: hacktobeer <ramsesdebeer@gmail.com> Co-authored-by: Aaron Peterson <aaronp@gmail.com>
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Mar 18, 2024
jleaniz
added a commit
to jleaniz/turbinia
that referenced
this pull request
Mar 18, 2024
* add workaround for pinfo warning output (google#1418) * Update version to 20231116.1 * Fix plaso dependencies (google#1420) * fix deps * fix test * Update version to 20231116.2 * Fix plaso dependencies (google#1420) * fix deps * fix test * update docs link --------- Co-authored-by: hacktobeer <ramsesdebeer@gmail.com> Co-authored-by: Aaron Peterson <aaronp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Make sure we only use the relevant json output of pinfo.py
Applicable issues
Additional information
Checklist