Vue 2 to 3 migration #1428
Merged
Vue 2 to 3 migration #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wajihyassine
changed the title
wajihyassine
changed the title
|
Web UI (Dark) Web UI (Light) |
|
Also @aarontp FYI for a high level look |
|
Filed #1434 to update the documentation in a separate PR |
|
Thanks for rebuilding the UI Wajih. Looks great! |
|
Ack, I will review this next week. |
|
Cool, yeah looks good from a high level and I'll defer to @berggren on the more detailed review since I don't know Vue :) Thanks. |
|
@berggren friendly ping if you can PTAL this week even from high level that would be awesome hoping this can be in the next release |
|
Chatting out of band going to merge this so it makes it into the next release, can always patch if needed |
jleaniz
pushed a commit
to jleaniz/turbinia
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Migrates the Turbinia Web UI from Vue 2 to Vue 3
Applicable issues
Additional information
Checklist