WIP: Add AWS EBS disk evidence type and processor #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Description of the change
Adds a new
AwsEbsVolumeevidence type for AWS EBS disks and the related pre/post-processors so we can attach and mount these disks.Other notes:
IsBlockDevice()to util moduleCLOUD_PROVIDERin config to be set toAWSApplicable issues
Fixes #1318
Additional information
Only certain disk types are compatible with multi-attach so this first iteration will only support those types, and for other disk types we'll only be able to support a single worker for now. In future PRs we'll try to come up with a method to process these disks, possibly by making a copy of the disk with a disk type that supports multi-attach.
Checklist