Add pre/post-process hooks for evidence #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is part of a fix for #42. Is there any specific syntax I need to use to reference that issue with this PR, but not actually close it? Or does the above work as intended? /me tests. |
berggren
approved these changes
Jun 21, 2017
turbinia/evidence.py
Outdated
| """Postprocess this evidence after the task runs. | ||
|
|
||
| This gets run in the context of the local task execution on the worker | ||
| nodes after the task itself runs. This can be used to clean-up after the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about this as a base implementation for {pre,post}-processing could work? I realized that almost all of the cases for preprocessing are related to specific evidence types, and we can use the normal inheritance mechanisms here to make things work. For example, the GoogleCloudDisk.preprocess() can do the attaching, and then it can call its parent's (RawDisk's) preprocess() to do the actual local mounting of the disk (if we wanted to actually mount it) too.
If we have a non-evidence specific type of pre/post processing that we want to do, I think we can implement that as decorators for the TurbiniaTask.run() methods, but I wasn't sure if we had a good use-case for that, so I didn't want to add it until we needed it.