Cleanup Vector2 #114
Merged
Cleanup Vector2 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Fox32
commented
Apr 8, 2015
Fox32
commented
- Remove duplicate implementation of some operations: they now delegate calls to another other method (e.g. add operator vs add method or length and length2). Inlining should make the whole thing perform as it did before.
- When a Vector is a argument, only get its storage once.
- Always access the private storage variable, this is a preparation for a future change.
- Doc comments.
- Making the shuffle getters aliases help to reduce the lines of the file, but the impact for Vector2 is quite small compated to Vector4.
Remove duplicate implementation of some operations: they now delegate calls to another other method (e.g. add operator vs add method or length and length2). Inlining should make the whole thing behave as it did before. When a Vector is a argument, only get its storage once. Always access the private storage variable, this is a preparation for a future change. Doc comments.
Closed
| @@ -6,7 +6,7 @@ part of vector_math; | |||
|
|
|||
| /// 2D column vector. | |||
| class Vector2 implements Vector { | |||
| final Float32List storage; | |||
There was a problem hiding this comment.
Doesn't this break implementing Vector? It has a public storage property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.