Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Vector3 #115

Merged
merged 3 commits into from
Apr 8, 2015
Merged

Cleanup Vector3 #115

merged 3 commits into from
Apr 8, 2015

Conversation

Fox32
Copy link
Contributor

@Fox32 Fox32 commented Apr 8, 2015

  • More or less the same changes as to Vector2
  • Move the Vector2 storage getter to the private field ;-)

@Fox32
Cleanup vector3
59df50a 
Always access private storage variable, inlining, remove duplicated code (as for Vector2)
Make the color and tex-coord shuffle getters (rggb, tsss) delegating to the xyz variants. This is not designed as a performance improvement but should only make the code better to read and makes the file some (houndred) lines shorter.
No new features => no new tests
@Fox32
Move getter closer to the private field
65c69eb
@Fox32
Format code
0526504 
Adapt the changes also for the latest changes
@Fox32 Fox32 mentioned this pull request Apr 8, 2015
Closed
johnmccutchan added a commit that referenced this pull request Apr 8, 2015
@johnmccutchan
Merge pull request #115 from Fox32/feature/cleanup-vector3
e02cea1 
Cleanup Vector3
@johnmccutchan johnmccutchan merged commit e02cea1 into google:master Apr 8, 2015
@Fox32 Fox32 deleted the feature/cleanup-vector3 branch April 13, 2015 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fox32 @johnmccutchan