Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenGL changes: #83

Merged
merged 4 commits into from Apr 9, 2015
Merged

OpenGL changes: #83

merged 4 commits into from Apr 9, 2015

Conversation

udhos
Copy link
Contributor

@udhos udhos commented Jan 29, 2015

  • Make setRotationMatrix() compatible, in respect to inversion, with setViewMatrix().
  • Add helper setModelMatrix().
  • Add slightly simpler/faster setViewMatrix2().

@udhos
OpenGL changes:
abf6534 
- Make setRotationMatrix() compatible, in respect to inversion, with
  setViewMatrix().
  - Add slightly simpler/faster setViewMatrix2().
@udhos
Sync'ed with upstream.
efd6b9d
@udhos udhos mentioned this pull request Mar 30, 2015
Closed
johnmccutchan
johnmccutchan reviewed Apr 6, 2015
View reviewed changes
lib/src/vector_math/opengl.dart
void setRotationMatrix(
Matrix4 rotationMatrix, Vector3 forwardDirection, upDirection) {
void setRotationMatrix(Matrix4 rotationMatrix, Vector3 forwardDirection,
Vector3 upDirection) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix formatting

@udhos
Copy link
Contributor Author

udhos commented Apr 6, 2015

John,

  1. fixed the formatting, but the formatter affected other lines as well.
  2. replaced setViewMatrix() with the new version.
    Thanks,
    Everton

@Fox32 Fox32 mentioned this pull request Apr 8, 2015
Closed
@udhos
Copy link
Contributor Author

udhos commented Apr 9, 2015

Please take another look at this request.

johnmccutchan added a commit that referenced this pull request Apr 9, 2015
@johnmccutchan
Merge pull request #83 from udhos/master
b5563c2 
OpenGL changes:
@johnmccutchan johnmccutchan merged commit b5563c2 into google:master Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@udhos @johnmccutchan