Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perl formatting support using Perltidy #227

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liuyehcf
Copy link

Solves #210

@dbarnett
Copy link
Contributor

Sorry, I think since the tests weren't passing this fell through the cracks. I think if you can rebase your changes on top of the latest upstream and address my comment there to fix the tests, this looks ready to merge otherwise.

must be installed on your system. (But not for testing; vroom intercepts
system calls.)
:FormatCode perltidy
! perltidy .*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fake the command output like this:

$ { "Cursor": 0 }

Otherwise the tests can't run without perltidy installed (and may get brittle, failing depending on the version of perltidy installed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants