Compare resolved paths in #GetOrInstall() #23
Conversation
| @@ -320,10 +320,13 @@ function! maktaba#plugin#GetOrInstall(dir, ...) abort | |||
| let l:settings = maktaba#ensure#IsList(get(a:, 1, [])) | |||
| if has_key(s:plugins, l:name) | |||
| let l:plugin = s:plugins[l:name] | |||
| let l:fullpath = s:Fullpath(a:dir) | |||
There was a problem hiding this comment.
s:Fullpath(a:dir) went away. About s:Fullpath(): I'm not sure what purpose it serves. The comment in s:Fullpath() says "The #Join ensures a trailing slash", but fnamemodify(a:location, ':p') already guarantees a trailing slash for paths ending in a directory name!
There was a problem hiding this comment.
l:plugin.location is the result of a call to s:Fullpath(), so it's probably a good idea to still call it for l:newpath for parallelism even if we can intuit that it's not necessary.
There was a problem hiding this comment.
Ok, just so I understand correctly: use s:Fullpath(a:dir) and then call fnamemodify() with :p:h on it. I will do that.
There was a problem hiding this comment.
Yep, that's what I had in mind.
And be sure to use the paths with trailing slash in the error message.
|
LGTM. |
Compare resolved paths in #GetOrInstall()
This fixes #18 for me. I don't have vroom to test this.
I understand if you prefer a different approach. Anyway, I've signed the CLA in the past so you can merge or roll your own solution as you please :)