Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a side effect of the plugin: the last substitute string is overwritten #20

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

liushapku
Copy link
Contributor

…itten

Before the change the call to s:MatchesInRange sets the last substitute string to ''

…itten

Before the change the call to s:MatchesInRange sets the last substitute string to `''`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@liushapku
Copy link
Contributor Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 5, 2018
@rburny rburny merged commit 576a701 into google:master Dec 5, 2018
@rburny
Copy link
Collaborator

rburny commented Dec 5, 2018

Thank you!

@dbarnett
Copy link
Contributor

Could also benefit from a comment to clarify what it does. Anyway, +1 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants