Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViSQOL uses protobuf-internal headers #1

Closed
gjasny opened this issue Apr 4, 2020 · 1 comment · Fixed by #23
Closed

ViSQOL uses protobuf-internal headers #1

gjasny opened this issue Apr 4, 2020 · 1 comment · Fixed by #23

Comments

@gjasny
Copy link
Contributor

gjasny commented Apr 4, 2020

Hello,

while building ViSQOL with CMake against a CMake-built protobuf I noticed that ViSQOL uses protobuf-internal headers like src/google/protobuf/stubs/statusor.h which won't be available in a CMake-protobuf installation.

I opened an issue in protocolbuffers/protobuf#7358 and asked to align both: the CMake and Bazel buildsystem in terms of installed or available headers. Based on the outcome you might lose access to StatusOr.

Are you aware of any replacement for StatusOr (e.g. in abseil-cpp)?

Thanks,
Gregor

@mchinen
Copy link
Collaborator

mchinen commented Apr 22, 2020

Hi, I'm not aware of a replacement for StatusOr, and I have seen several projects using protobuf/stubs/statusor.h; I think the issue you opened up in the protobuf repo should be enlightening. For your situation it seems the hacky workaround will be to manually copy the headers or use a search path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants