Input validation for add_categorical_param.

PiperOrigin-RevId: 573967682
google · Oct 17, 2023 · 42405af · 42405af
1 parent c5e243f
commit 42405af
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/vizier/_src/pyvizier/shared/parameter_config.py b/vizier/_src/pyvizier/shared/parameter_config.py
@@ -977,8 +977,13 @@ def add_categorical_param(
       ParameterConfigSelector for the newly added parameter(s).
 
     Raises:
-      ValueError: If `index` is invalid (e.g. negative).
+      ValueError: If `index` is invalid (e.g. negative), or `feasible_values`
+        are invalid (not strings).
     """
+    for value in feasible_values:
+      if not isinstance(value, str):
+        raise ValueError(f'feasible_values must be strings; got: {value}')
+
     param_names = self._get_parameter_names_to_create(name=name, index=index)
 
     new_params = []

diff --git a/vizier/_src/pyvizier/shared/parameter_config_test.py b/vizier/_src/pyvizier/shared/parameter_config_test.py
@@ -541,6 +541,12 @@ def testParseMultiDimensionalParameterName(self, name, expected):
         name)
     self.assertEqual(base_name_index, expected)
 
+  def testValidateCategoricalInput(self):
+    space = pc.SearchSpace()
+    root = space.select_root()
+    with self.assertRaises(ValueError):
+      root.add_categorical_param('categorical', ['3.2', '2', 5])
+
 
 class SearchSpaceContainsTest(absltest.TestCase):