Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestQueueIntegrationTest is flaky #56

Closed
jpd236 opened this issue Jul 18, 2017 · 0 comments
Closed

RequestQueueIntegrationTest is flaky #56

jpd236 opened this issue Jul 18, 2017 · 0 comments
Milestone
1.1.0

Comments

@jpd236
Copy link
Collaborator

jpd236 commented Jul 18, 2017

https://travis-ci.org/google/volley/builds/254582777?utm_source=github_status&utm_medium=notification

com.android.volley.RequestQueueIntegrationTest > add_requestProcessedInCorrectOrder FAILED
org.mockito.exceptions.verification.WantedButNotInvoked at RequestQueueIntegrationTest.java:96
@jpd236 jpd236 mentioned this issue Jul 18, 2017
Merged
jpd236 added a commit to jpd236/volley that referenced this issue Sep 19, 2017
@jpd236
Fix RequestQueueIntegrationTest flakiness.
f9ee54f 
Test failures were due to listeners not being invoked fast enough by
background threads; the timeouts seem to have been aggressive to work
around an old Mockito limitation about not being able to verify the
order of calls. So migrate to new Mockito APIs that allow this, and
dramatically increase timeouts to try and avoid flakiness.

Fixes google#56
jpd236 added a commit to jpd236/volley that referenced this issue Sep 19, 2017
@jpd236
Fix RequestQueueIntegrationTest flakiness.
3ec439c 
Test failures were due to listeners not being invoked fast enough by
background threads; the timeouts seem to have been aggressive to work
around an old Mockito limitation about not being able to verify the
order of calls. So migrate to new Mockito APIs that allow this, and
dramatically increase timeouts to try and avoid flakiness.

Fixes google#56
@jpd236 jpd236 mentioned this issue Sep 19, 2017
Merged
jpd236 added a commit that referenced this issue Sep 19, 2017
@jpd236
Fix RequestQueueIntegrationTest flakiness. (#94)
e16a426 
Test failures were due to listeners not being invoked fast enough by
background threads; the timeouts seem to have been aggressive to work
around an old Mockito limitation about not being able to verify the
order of calls. So migrate to new Mockito APIs that allow this, and
dramatically increase timeouts to try and avoid flakiness.

Fixes #56
@GulajavaMinistudio GulajavaMinistudio mentioned this issue Sep 20, 2017
Merged
@jpd236 jpd236 added this to the 1.0.1 milestone Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@jpd236