coding style #18
Merged
coding style #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the cleanup! |
|
Thank you! |
jpd236
reviewed
Aug 8, 2017
| @@ -87,12 +87,12 @@ | |||
| public Map<String, String> responseHeaders = Collections.emptyMap(); | |||
|
|
|||
| /** True if the entry is expired. */ | |||
| public boolean isExpired() { | |||
| boolean isExpired() { | |||
There was a problem hiding this comment.
I missed that these are methods in a class, not an interface. This was a functional change that should be reverted. (I'll take care of this)
jpd236
added a commit
that referenced
this pull request
Aug 8, 2017
Cache.Entry is a class, not an interface; its methods should never have been made package-private as they were part of the public Volley API.
jpd236
added a commit
that referenced
this pull request
Aug 8, 2017
Fix regression introduced by #18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixed a few things that Lint has picked up like redundant 'public' modifiers for interface methods and simpler generic syntax for Java7.