Refactor Volley into a multi-module project. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbiral
approved these changes
Jul 6, 2021
This splits the library into three Gradle modules: - core - volley core + toolbox - cronet - CronetHttpStack - testing - common testing code The primary purpose is to split out CronetHttpStack into its own Maven artifact, com.android.volley:volley-cronet, to prevent applications which aren't using it from having to either suppress Proguard/D8 warnings or pull in the unnecessary dependency. The testing module is needed to share TestRequest between unit tests in both core and cronet. It is not published to Maven. This PR also removes support for the build.gradle/rules.gradle split which allowed Gradle projects to depend on Volley by source and specify their own SDK settings. This is no longer worth supporting, and any client that wishes to depend on Volley via Gradle should do so via published Maven artifacts instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the library into three Gradle modules:
The primary purpose is to split out CronetHttpStack into its own Maven
artifact, com.android.volley:volley-cronet, to prevent applications
which aren't using it from having to either suppress Proguard/D8
warnings or pull in the unnecessary dependency.
The testing module is needed to share TestRequest between unit tests
in both core and cronet. It is not published to Maven.
This PR also removes support for the build.gradle/rules.gradle split
which allowed Gradle projects to depend on Volley by source and
specify their own SDK settings. This is no longer worth supporting,
and any client that wishes to depend on Volley via Gradle should do
so via published Maven artifacts instead.
See #412