-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We don't have a reliable way to tell when commands have finished executing #2
Comments
I'm the author of vimrunner, a project that also tries to drive Vim using the My solution is to just always use The relevant code for commands is here. The |
Awesome, thanks! We were evaluating that approach, but hit some snags with special key codes, continued lines, and error handling and haven't finished getting something working yet. But glad to know it's feasible. |
Yeah, escaping can be annoying when you pass things around a bunch of strings that are then given to arguments to functions that are then sent through the remote interface. I would suggest you browse through the relevant Vimrunner code, since it seems to be working well in practice (even so, I'd appreciate reports of any bugs/inconsistencies you notice in there :)). |
Ah, also, just noticed you mentioned error handling. I may sit down and write a lengthy explanation of what I remember of my own problems/solutions in that area, but I'll see if I find the time. |
One special case I noticed is it seems to have trouble with executing shell commands in the foreground (with |
This single problem leads to a host of other issues. Mostly, it forces us to use arbitrary delays between commands (instead of having some way of knowing when commands are finished). This slows down the tests considerably.
Furthermore, it means that we can't reliably know whether messages were dropped or whether we just haven't waited long enough yet. Which sucks.
The text was updated successfully, but these errors were encountered: