Added support for Layer Interface Version 0 in the pipeline runtime layer #157
Conversation
There was a problem hiding this comment.
Thanks for improving this, @mdagois!
This seems to only update the runtime layers -- did you omit the other layers intentionally? If so, could you update the PR description and title to mention that this is for the runtime layer only?
layer/runtime/runtime_layer.cc
Outdated
| #define LAYER_NAME "VK_LAYER_STADIA_pipeline_runtime" | ||
|
|
||
| constexpr uint32_t kRuntimeLayerVersion = 1; | ||
| constexpr char kLayerName[] = "VK_LAYER_STADIA_pipeline_runtime"; | ||
| constexpr char kLayerName[] = LAYER_NAME; |
There was a problem hiding this comment.
Do we need this define? I don't see it being used anywhere else
There was a problem hiding this comment.
Oops, sorry, I added the LAYER_NAME define and forgot to actually use it.
LAYER_NAME is now also used to build the entry point function names for Layer Interface Version 0 (see LAYER_NAME_FUNCTION macro).
I realized there were several issues around those macros, so I fixed them.
It requires a lot of macro gymnastics, but the intent is to have the layer name defined in one single place, because
if we change the layer name later and forget to update the entry point names, there won't be any compilation error, but the layer won't work on Android anymore.
I hope that makes sense.
mdagois
changed the title
Yes, it was intentional. |
Layer Interface Version 0 support + Android in the pipeline runtime layer