Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored weather-mv to work with pluggable Data Sinks. #101

Merged
merged 10 commits into from
Feb 9, 2022
Merged

Conversation

alxmrs
Copy link
Collaborator

@alxmrs alxmrs commented Feb 1, 2022

  • Created abstraction for Data Sinks (where weather data can be moved to)
  • Pulled out existing pipeline into a BigQuery sink
  • Added more tests (for example, of the CLI).
  • Added dataclasses as a project dependency for older python versions
  • Updated class documentation

- Created abstraction for Data Sinks (where weather data can be moved to)
- Pulled out existing pipeline into a BigQuery sink
- Added test stubs
- Added `dataclasses` as a project dependency for older python versions

TODO:
- e2e test of the weather mover
- implement tests
- document
@alxmrs alxmrs marked this pull request as ready for review February 8, 2022 00:51
Copy link
Collaborator

@pramodg pramodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I really the approach of splitting the single file up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants