(#123) Fixed beam not being able to access global namespace + minor related bug. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed related bug where save_main_session arg for run() wasn't doing anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beam pipeline wasn't able to see the global namespace, despite that save_main_session=True was passed to the pipeline options. I'm not sure why save_main_session wasn't having its intended effect, but I worked around it by importing the global symbols that the pipeline wasn't able to see.
I also noticed that the save_main_session argument to run() wasn't actually doing anything, and that argument to the pipeline was always set to True, so I fixed that.