Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cfgrib multiple hypercubes by normalizing the schema #184

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Support cfgrib multiple hypercubes by normalizing the schema #184

merged 6 commits into from
Jul 11, 2022

Conversation

mahrsee1997
Copy link
Collaborator

Fixes #73.

@mahrsee1997 mahrsee1997 mentioned this pull request Jul 6, 2022
Closed
@mahrsee1997 mahrsee1997 requested a review from alxmrs July 6, 2022 11:37
alxmrs
alxmrs reviewed Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@alxmrs alxmrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll finish the review tomorrow; here is a first pass.

weather_mv/loader_pipeline/bq_test.py Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Show resolved Hide resolved
@mahrsee1997 mahrsee1997 requested a review from alxmrs July 7, 2022 18:05
alxmrs
alxmrs reviewed Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@alxmrs alxmrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made another pass. I had a late breaking idea, which is to make use of xr.Dataset attrs. Also, let's follow up with a discussion about another part of the PR.

weather_mv/README.md Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/bq.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/bq.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/bq.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/sinks.py Show resolved Hide resolved
weather_mv/loader_pipeline/util.py Show resolved Hide resolved
weather_mv/loader_pipeline/util.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/util.py Outdated Show resolved Hide resolved
weather_mv/loader_pipeline/util.py Outdated Show resolved Hide resolved
@mahrsee1997 mahrsee1997 marked this pull request as ready for review July 8, 2022 17:18
@mahrsee1997 mahrsee1997 requested a review from alxmrs July 8, 2022 17:18
alxmrs
alxmrs approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@alxmrs alxmrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However: There's one discrepancy between two places in the docs. Please fix this before merge.

weather_mv/loader_pipeline/bq.py Show resolved Hide resolved
weather_mv/loader_pipeline/bq_test.py Show resolved Hide resolved
@mahrsee1997 mahrsee1997 merged commit 3e7580a into main Jul 11, 2022
@mahrsee1997 mahrsee1997 deleted the mv-hypercubes-cfgrib branch July 11, 2022 17:54
@alxmrs alxmrs mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxmrs alxmrs alxmrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skipping variable error
2 participants
@mahrsee1997 @alxmrs