Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BrowserSync.reload call in jshint command always returns 0 file changed #593

Closed
rdmurphy opened this issue Jan 11, 2015 · 3 comments · May be fixed by tobybellwood/govstrap#4
Closed

BrowserSync.reload call in jshint command always returns 0 file changed #593

rdmurphy opened this issue Jan 11, 2015 · 3 comments · May be fixed by tobybellwood/govstrap#4

Comments

@rdmurphy
Copy link

Hello!

This line in the gulpfile.js appears to be trying to pass along to BrowserSync the number and names of the files being linted, but it always returns 0 file changed ().

screen shot 2015-01-11 at 11 09 55 am

I actually came across this with a version of the starter kit I customized to add a scripts call for concatenation + uglifying and it does the same thing there. And then I noticed it was happening twice, so I kept going up the chain and found this.

Totally possible this is on the BrowserSync side of things – not really knowledgeable enough about it to hack around on it to figure it out – but currently that is not providing any useful logged information. Could be an order of operations thing?

Hope that helps!
@rdmurphy rdmurphy changed the title BrowserSync.reload call in jshint command always returns 0 files changed BrowserSync.reload call in jshint command always returns 0 file changed Jan 11, 2015
shakyShane added a commit to BrowserSync/browser-sync that referenced this issue Feb 10, 2015
@shakyShane
fix(stream): Don't log file info when once: true - fixes google/web-s…
8f4d727 
…tarter-kit#593
christianvuerings added a commit to christianvuerings/browser-sync that referenced this issue Feb 11, 2015
@christianvuerings
Fix Changelog for 2.0.1
28a40ff 
Fix the link from
https://github.com/google/web-starte
to
google/web-starter-kit#593
@christianvuerings christianvuerings mentioned this issue Feb 11, 2015
Merged
@stevemao
Copy link
Contributor

Looks like this issue is solved.

@rdmurphy
Copy link
Author

Thanks! 👍

@addyosmani
Copy link
Contributor

Closing as fixed.

@dependabot-preview dependabot-preview bot mentioned this issue Mar 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump browser-sync from 2.23.5 to 2.23.6 tobybellwood/govstrap
3 participants
@addyosmani @rdmurphy @stevemao