Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify server configuration - remove 'baseDir' #419

Merged
merged 1 commit into from
Sep 2, 2014

Conversation

shakyShane
Copy link
Contributor

Projects that only use the baseDir option can safely promote it to being the value of server

server: {
  baseDir: "./app"
}

is exactly the same (to BrowserSync) as:

server: "./app"

This would not work should you wish to use any other server options in the future - but for the current configuration, it does make the gulpfile that little bit cleaner.

@addyosmani
Copy link
Contributor

Thanks for the PR! Before this can be merged, please sign the CLA at https://developers.google.com/open-source/cla/individual

@shakyShane
Copy link
Contributor Author

Done - maybe worth noting that I had previously done this... is it once per pull request now?

:)

@addyosmani
Copy link
Contributor

Achievement unlocked: CLA signature found!

@sindresorhus
Copy link
Contributor

Done - maybe worth noting that I had previously done this...

@addyosmani ?

sindresorhus added a commit that referenced this pull request Sep 2, 2014
Simplify server configuration - remove 'baseDir'
@sindresorhus sindresorhus merged commit 1addf78 into google:master Sep 2, 2014
@sindresorhus
Copy link
Contributor

Thanks @shakyShane :)

@addyosmani
Copy link
Contributor

Sorry for the automated CLA verified being a little on the fritz. Appreciate the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants