Replace deprecated minifiers with gulp-cssnano and gulp-htmlmin #804
Conversation
gulp-htmlmin currently has to be manually configured; there are no sensible defaults. These transforms are all relatively safe, and in my experience provide the bulk of HTML minification gains.
|
Thanks for the PR, @robwierzbowski! I was planning on getting this updated but got swamped. Really appreciate you writing the patch. |
|
LGTM |
…ifiers Replace deprecated minifiers with gulp-cssnano and gulp-htmlmin
|
@robwierzbowski btw, interested in helping us maintain the repo? You've been great at helping out with PRs for quite some time and I think we should just give you committer rights if you're interested. |
|
@addyosmani That would be great :D. At some point in the near future I'm going to move one of my projects to gulp 4. If it works out maybe I'll give converting WSK a try. |
|
@robwierzbowski We're planning on moving everything to Gulp 4 soooon :) @gauntface and @surma are taking a look at that over in https://github.com/google/web-starter-kit/tree/wsk2 |
|
@robwierzbowski you should have commit rights now ⚡ |
|
Awesome! |
|
|
|
@robwierzbowski You may want to take a look at the super secret |
|
@surma Yeah, I poked around a little. Looks great, looking forward to contributing to it soon! |
Fixes #802.
Replaces deprecated minify-html and minify-css plugins with recommended plugins htmlmin and cssnano.
gulp-htmlmin currently has to be manually configured; there are no sensible defaults. These transforms are all relatively safe, and in my experience provide the bulk of HTML minification gains, but I'm open to any changes.